-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gengchen528 patch 1 #737
Gengchen528 patch 1 #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to have this epic article for announcing our new Web Protocol for Wechaty users!
I have two suggestions for your article, could you please follow my suggestion and update it?
I'll be ok if you want to merge this article without those changes by letting me know that.
Thank you very much!
function onScan(qrcode, status) { | ||
require('qrcode-terminal').generate(qrcode); // 在console端显示二维码 | ||
const qrcodeImageUrl = [ | ||
'https://api.qrserver.com/v1/create-qr-code/?data=', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have our own QR Code online generator now, please replace api.qrserver.com
to https://wechaty.js.org/qrcode/XXX
because our service will be more reliable.
let bot = ''; | ||
bot = new Wechaty({ | ||
name, // generate xxxx.memory-card.json and save login data for the next login | ||
puppet: 'wechaty-puppet-wechat', // 注意必须配置这个 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove the puppet
setting here, instead, use export WECHATY_PUPPET=wechaty-puppet-wechat
to make the code more portable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for this great article, and appreciate for your great PR for wechaty/puppet-wechat#127 ! |
Please make sure to check the following boxes creating your pull request, thank you very much!
[ * ] Add Blog Header, including title, author, image, categories, tags, etc.
For example:
[ * ] Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
[ * ] Embed video/pdf from YouTube/Bilibili/local (if there's any) by using
{% include iframe.html src="URL_or_PATH" %}
. (Learn more about how to embed file/url in the post by reading this blog post[* ] Save photo to local before publishing, to a folder named by
${MONTH}-${YOUR_BLOG_SLUG}/
under/assets/2021/
directory.[ * ] Select a beautiful and meaningful teaser image for your blog
[ * ] Create your contributor profile (if you are a first time contributor)
For excample:
Here is the example file:
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/