Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 new api overview #1527

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: 🎸 new api overview #1527

wants to merge 4 commits into from

Conversation

hcfw007
Copy link
Member

@hcfw007 hcfw007 commented Aug 10, 2023 •
edited
Loading

As we agreed in this PR #1525 (comment)
New doc will be pushed section by section. The next section will only be pushed if the previous one is approved.
And after all sections are pushed and approved, this PR will be merged.

@hcfw007 hcfw007 mentioned this pull request Aug 10, 2023
Open
3 tasks
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@windmemory windmemory requested a review from huan December 11, 2023 08:54
windmemory
windmemory previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2023
huan
huan approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@huan huan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan enabled auto-merge (squash) January 4, 2024 02:33
huan
huan previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for improving this doc page!

@huan
Copy link
Member

huan commented Jan 24, 2024

@hcfw007 this PR needs one more approval to trigger the auto-merge, which I had set a long time ago. Please get your PR merged. Thanks!

@hcfw007
Copy link
Member Author

hcfw007 commented Jan 25, 2024

@hcfw007 this PR needs one more approval to trigger the auto-merge, which I had set a long time ago. Please get your PR merged. Thanks!

According to our previous discussion, we should review this new doc chapter by chatper. So I'm working to get the seconder chapter pushed. However I'm trying to solve a. prolem preventing me from clone the repo.

image

auto-merge was automatically disabled January 29, 2024 08:27

Head branch was pushed to by a user without write access

@hcfw007 hcfw007 dismissed stale reviews from windmemory and huan via 7eb0ac5 January 29, 2024 08:27
@hcfw007
Copy link
Member Author

hcfw007 commented Jan 29, 2024

@huan I solved the newtwork problem. Now the second section is ready to be reviewed.

@huan
Copy link
Member

huan commented Jan 29, 2024

I don't think the hello-world should be put under the Reference/API folder.

Can you remove it? Or please explain why it can be put under this folder, according to the Documentation System methodology. See: https://wechaty.js.org/2021/03/25/google-season-of-docs-documentation-system/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmemory windmemory windmemory left review comments

@huan huan huan left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcfw007 @huan @windmemory