Set widget BASE_TARGET on ENV variables #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to decide where the widget's links should be open. The PR makes it possible to set an ENV variable at build time to open the links in a new tab by setting BASE_TARGET to _blank.
|
|
widget/.env.development
Outdated
| @@ -0,0 +1 @@ | |||
| BASE_TARGET="_parent" | |||
There was a problem hiding this comment.
I think we can remove this file
runephilosof-abtion
approved these changes
Aug 21, 2024
|
@hcarreras This looks useful. However, wouldn't it be better to add this as an option under chatbot customizations? This way, users can choose whether the links should open in the parent window or in a new tab for each chatbot. |
|
I agree that'd be even better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to decide where the widget's links should be open.
The PR makes it possible to set an ENV variable at build time to open the links in a new tab by setting BASE_TARGET to _blank.