Add webview_step
#735
Closed
Add webview_step
#735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justjosias @dandeto mind reviewing? |
|
Do you have any examples that can be tested to make sure everything works appropriately? I'd be useful for testing this to be included in CI. |
This was referenced May 25, 2022
justjosias
reviewed
May 31, 2022
|
Closing this in favour of webview/webview_deno#112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr re-adds support for the previously called
webview_loopmethod now calledwebview_stepallowing for the application to take a single step in the event loop instead of blocking and running until it's exited.A few related issues, but mainly the first one:
#578 #652 #12
What still needs to be done is mac support, and I might be able to add that if my work computer decides to co-operate, but I would certainly appreciate help from any mac guru as I have never touched the mac stuff and it looks scary...