-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary quotes from front-end pages and email templates #201
Comments
@raamdev Hi Raam, PR submitted, do I need to repeat for Pro? Or do they have the same templates? |
I just want to go on record as disagreeing with this change request. It's common practice to quote titles, particularly when it would be easy to misunderstand that it is a title. Since a Post can potentially have a strange title, quoting it helps to ensure that someone can see it is all one entity; i.e., a title. If quotes are not desirable, then I suggest an alternative approach. In either case though, it should be easy to see that the title is a full string of words that are separate from the wording used around it. Imagine a Post with the title...
Now incorporate that into a sentence as seen above...
is far less confusing than...
Removing the quotes could potentially lead to more confusion, not less. |
I suggest the use of italics instead of quotes. |
To repeat: I was saying there must not be any quotes around the website NAME and similar items. While "It's common practice to quote titles", yes, it's misleading to "quote" a NAME (here the website). Have you ever seen, say the NY Times etc, to write: |
@renzms Please update your PRs (yes, we need PRs for Lite and Pro) with the following:
|
It's ridiculous, but I never saw ANY mention of websharks FROM websharks where you felt the need to put your own name in italics or in quotes! what a time-waste for me when trying to help/open eyes... |
@RealDavidoff What is the problem? You asked us to fix something and we're fixing it. It's hard to help when you don't want to see that we're doing exactly as you asked. |
But you aren't. Just read it tomorrow, afresh. On 25 January 2016 at 17:51, Raam Dev notifications@github.com wrote:
|
@RealDavidoff If my comment felt personal, it was not. I assure you. I respect and appreciate your feedback here, and you have pointed out several ways that we can improve. Props! However, working through issues in code, contemplating other angles, these are things that require various people and respect for differing opinions. Statements like, "It's ridiculous", and "what a time-waste for me", is not you looking at the problem objectively and showing respect for the feedback that I have about this. This is about the end result. No quotes, italics instead. That's an improvement. One that is coming about as a result of feedback we got from you. Thanks! You replied...
It's the similar items that we are working with right now. For instance, you suggested previously...
Right now we are working with titles. |
@raamdev @jaswsinc > Please update your PRs (yes, we need PRs for Lite and Pro) with the following:
Got it, will update for Pro and Lite and use italics in place of the quotes for emphasis. |
@RealDavidoff writes...
Yes, please read it afresh tomorrow and you'll see that we are, in fact, doing exactly as you asked: Removing quotes. They are being replaced with |
Submit PR for both Pro and Lite for review. Thanks! |
Hi, updated for type A. Ready for review, thanks! |
Next Lite Release Changelog:
|
Next Pro Release Changelog:
|
Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#201). |
@RealDavidoff writes in #199 (comment)...
The text was updated successfully, but these errors were encountered: