"Comment Mail is disabled" notice margin is missing

[raamdev]

The .notice-warning class that is used for the "Comment Mail is disabled" notice needs the following style to fix alignment issues:

margin: 1.25em 1.25em 1.25em .25em;

[raamdev]

Note that this needs to be changed in both Comment Mail Lite and Comment Mail Pro.

[renzms]

PRs submitted! 👍

[raamdev]

@renzms Thank you! I tested your PR and confirmed the Disabled notice is now aligned properly:

[raamdev]

One thing I did notice during testing is that when you visit the Subscribe to Comments Reloaded options page, the StCR menu at the top clashes with these two Dashboard notices generated by Comment Mail:

This is really the fault of StCR and not Comment Mail, however given that new Comment Mail users who are migrating from StCR are likely to visit their StCR options page, I feel we should at least attempt to fix this clash to make the issue not quite as obvious.

I'm pushing a fix to the PRs submitted by @renzms that will resolve this issue on the StCR options page:

[raamdev]

Next Lite Release Changelog:

• Bug Fix: Fixed a UI bug where some of the Dashboard notices generated by Comment Mail were either misaligned or were clashing with the Subscribe to Comments Reloaded options menu. Props @renzms. See Issue #186.

[raamdev]

Next Pro Release Changelog:

• Bug Fix: Fixed a UI bug where some of the Dashboard notices generated by Comment Mail were either misaligned or were clashing with the Subscribe to Comments Reloaded options menu. Props @renzms. See Issue #186.

[raamdev]

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#186).

[Reedyseth]

Guys just FYI,

This Dashes are removed and included on my latest changes of StCR.

[raamdev]

@Reedyseth Can you point me to the commit on GitHub where you made that change in StCR?

[Reedyseth]

Can you point me to the commit on GitHub where you made that change in StCR?

Sure, they are on a development branch on this commit stcr/subscribe-to-comments-reloaded@ec65388

@ the file subscribe-to-comments-reloaded/style.css

[jaswrks]

This Dashes are removed and included on my latest changes of StCR.

Copy that. Thanks.

[raamdev]

@Reedyseth The problem isn't the dashed style; the problem is that the <h2> element that the StCR links are inside are overflowing onto Divs that show up underneath it.

I've opened a new GitHub issue with screenshots on the StCR repo, along with a suggested way of fixing the problem (that I've tested); see stcr/subscribe-to-comments-reloaded#158.