Restore Default Options doesn't restore default options

[raamdev]

Testing the dev branch (as of 2015-12-15) of Comment Mail Pro, clicking "Restore Default Options" doesn't actually restore any default options. You can test this by enabling the plugin or disabling data safeguards, saving options, and then clicking "Restore Default Options". The defaults (Comment Mail disabled, Data Safeguards enabled) should be restored, but they are not.

[raamdev]

This probably also affects Comment Mail Lite, but I haven't confirmed yet.

[jaswrks]

Try changing this line. Instead of '1' use:

$args = array(__NAMESPACE__ => array('restore_default_options' => time()));

I think this is a browser caching quirk. The redirection is getting cached.

[raamdev]

I think this is a browser caching quirk. The redirection is getting cached.

I think you're right. I realized I was testing on my personal site, where there are quite a few plugins. I just tested on my clean install and the Restore Defaults works fine.

[raamdev]

Try changing this line. Instead of '1' use:

Confirmed. This fixes the issue.

[raamdev]

@renzms Could you submit a PR for me? For both Pro and Lite.

[renzms]

@raamdev PRs submitted!

[raamdev]

Next Lite Release Changelog:

• Bug Fix: Fixed a bug with "Restore Default Options" that was introducing a browser quirk that was preventing the default options from being restored. Props @renzms. See Issue #181.

[raamdev]

Next Pro Release Changelog:

• Bug Fix: Fixed a bug with "Restore Default Options" that was introducing a browser quirk that was preventing the default options from being restored. Props @renzms. See Issue #181.

[raamdev]

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#181).