This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
Add main parts of SFU example #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0nserv
reviewed
Jun 24, 2022
| while let Ok(signal) = socket_rx.recv_async().await { | ||
| match signal { | ||
| SocketMessage { event, uuid: id, data: sdp } if event == "offer" => { | ||
| println!("\nReceiving offer: {:?}, for uuid: {:?}\n", sdp, id); |
There was a problem hiding this comment.
Should use log::info or so for these, no printlns
| uuid: id.to_owned(), | ||
| tx: socket_tx.clone(), | ||
| sdp | ||
| }).unwrap(); |
There was a problem hiding this comment.
expect instead of unwrap if we don't think this can happen. Alternatively if the receiver is gone should this task halt?
| for (_k, p) in &peers { | ||
| match p.local_video_tracks.get(&uuid) { | ||
| Some(track) => { | ||
| if let Err(err) = track.write_rtp(&packet).await { |
There was a problem hiding this comment.
These futures can be created, collected into a Vec and then ran concurrently with futures::join_all
|
|
||
| async fn simple_file_send(filename: &str) -> Result<Response<Body>, anyhow::Error> { | ||
| // Serve a file by asynchronously reading it by chunks using tokio-util crate. | ||
| if let Ok(file) = tokio::fs::File::open(filename).await { |
There was a problem hiding this comment.
If filename is user controlled this can trigger a path traversal vulnerability.
|
We have migrated this crate to the monorepo(webrtc-rs/webrtc) please re-open this pull request over there or perhaps for this case in the SFU repo? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a simple example of a Selective Forwarding Unit.
There's a little bit of cleanup I'll add shortly, but the big elephant in the room is this branch only works on the
mainbranch ofwebrtc-rs. I've set it as such here so that people can try it out by just pulling this branch, but ultimately we can't merge this until there's a new release, at which point we can tag the whole examples version to 0.5.