add support for type meta to service method arguments #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reviewing |
VojtechVitek
added a commit
to golang-cz/webrpc
that referenced
this pull request
Aug 25, 2023
VojtechVitek
added a commit
to webrpc/webrpc
that referenced
this pull request
Aug 25, 2023
Update to golang@v0.13.1 - webrpc/gen-golang#31 - webrpc/gen-golang#36 - webrpc/gen-golang#35 - webrpc/gen-golang#34 - webrpc/gen-golang#33 - webrpc/gen-golang#32 - webrpc/gen-golang#37
| {{- $inputVar := "nil" -}} | ||
| {{- $outputVar := "nil" -}} | ||
| {{- if $inputs | len}} | ||
| {{- $inputVar = "in"}} | ||
| in := struct { | ||
| {{- range $i, $input := $inputs}} | ||
| Arg{{$i}} {{template "type" dict "Type" $input.Type "Optional" $input.Optional "TypeMap" $typeMap "TypePrefix" $typePrefix}} `json:"{{$input.Name}}"` | ||
| Arg{{$i}} {{template "field" dict "Name" $input.Name "Type" $input.Type "Optional" $input.Optional "TypeMap" $typeMap "TypePrefix" $typePrefix "TypeMeta" $input.Meta "JsonTags" true}} |
There was a problem hiding this comment.
input.Meta here relies on https://github.com/webrpc/webrpc/pull/229/files#r1329822795
darkhorse0311
added a commit
to darkhorse0311/WebRPC
that referenced
this pull request
Apr 27, 2024
Update to golang@v0.13.1 - webrpc/gen-golang#31 - webrpc/gen-golang#36 - webrpc/gen-golang#35 - webrpc/gen-golang#34 - webrpc/gen-golang#33 - webrpc/gen-golang#32 - webrpc/gen-golang#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on the type.go.tmpl renaming it to field.go.tmpl so it can account for the type meta annotations. A field can be used in many places outside of the struct, so moved some of the logic around, and added some flags if to include json / struct tags or not, etc.