Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe if it fails to % - encode headers #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manueldeprada
Copy link

If Warcio fails to % encode headers, at least when dealing with the exception replace the non-encodeable chracters with a stub. This is not an ideal fix, but at least WARCIO does not fail to decode and encode the same file and the most probable outcome is that a strange cookie gets a few chars replaced.

Temporary fix for issue: #128
Until headers are treated as a byte stream when reencoding a file.

If Warcio fails to % encode headers, at least when dealing with the exception replace the non-encodeable chracters with a stub. This is not an ideal fix, but at least WARCIO does not fail to decode and encode the same file and the most probable outcome is that a strange cookie gets a few chars replaced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant