Convert to Manifest V3 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename chrome.browserAction -> chrome.action include ext/bg.js in sw/main.js (addresses #131) move replay root to ./ from ./replay/ dynamically import sw.js from bg.js, use bg.js as service-worker entrypoint ipfs: add Origin header overrides via declarative-net-request rules, also add as permission via brave-ipfs.json rules bump version to 0.10.0
|
This is ready to go, but awaiting implementation of 'strong keep-alive' for chrome.debugger APIs: |
|
@ikreymer I think |
update paths for extension
- use RWP init path for embeds, including init SW - fix embed pacge styling
remove embed data from dist/ readd flexsearch dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts ArchiveWeb.page to work in Manifest V3
Some caveats:
Currently, the dev build doesn't load due to CSP restrictions (hopefully this will be allowed at some point at least for unpacked extensions, see: https://bugs.chromium.org/p/chromium/issues/detail?id=1159293)chrome-extension://<id>/index.htmlinstead ofchrome-extension://<id>/replay/index.htmlas the service worker registration is no longer needed.Brave IPFS: Using declarativeNetRequest to override Origin header to allow access to local IPFS node (may need more work)not adding for now, since this is being deprecated Deprecate local node support and ipfs:// scheme brave/brave-browser#37735