-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to webpack 3 and Upgrade Antwar #980
Conversation
3a897e7
to
38b2fb4
Compare
b227634
to
d371957
Compare
c9862bc
to
0ce9fc0
Compare
Ok so here’s what i’m seeing:
Aside from those I'm not seeing anything else broken but i'll keep poking around. I can look into to the two sidebar issues but I'm not sure what to do about the titles. It would be great if we could put that one to bed and close out #720. I restarted the build as well to see if anything fails -- the last one got terminated somehow. |
Ok updated the lead-in description with what's left to do... I fixed two issues with the normal sidebar and will now look into the mobile sidebar. Also working on simplifying the webpack config even more. |
Yeah so the issue with the |
f492608
to
70379d5
Compare
I upgraded the setup to use webpack 3 and fixed titles. Can you check the mobile sidebar bit? Also that termination issue remains most likely (some way to debug is needed). |
@bebraw I'll pull, test, and try to resolve the mobile sidebar issue. I restarted the build just to see if that would help, but honestly I'm not really an expert when it comes to CI. Although I just checked the build and it seems to be moving past the initial stages now. |
> webpack.js.org@0.1.2 lint:links /home/travis/build/webpack/webpack.js.org
> hyperlink -r build/index.html | ./scripts/check-links.js
Guessing --root from input files: file:///home/travis/build/webpack/webpack.js.org/build/
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated Not really sure what's failing here, is it |
@bebraw I'm unable to find the necessary data within I'm also not seeing the titles populated: Please advise... I did wipe my |
95e6a1e
to
c20a0b1
Compare
e409654
to
123b6b3
Compare
123b6b3
to
acfeb17
Compare
This is still not ideal but at least renders the correct title and anchors for all index pages. Added a TODO noting how it should probably be resolved long term.
Now that titles and anchors are displayed these pages are a bit more prominent.
Submitted Banno/polymer-webpack-loader#63 to fix the last remaining issue. @pierreneter I'm going to do another pass over all this and see if there's anything else that needs fixing or can be cleaned up. Expect it to be merged by the end of this week (this weekend at the latest). |
a3522c1
to
cc4c8b9
Compare
cc4c8b9
to
6d3f768
Compare
4e1beb9 related to: get-alex/alex#175
and
|
Will do a final pass over this tonight and get it merged. |
Ignore the "sucks" mention in the npm-install-webpack-plugin file for now. It isn't used in a derogatory way so I'm not sure we should change it but I'm also not sure we should `allow` "sucks" globally.
Ok @pierreneter tested this out and everything seems good to go. I did just submit webpack-contrib/install-webpack-plugin#118 to fix a broken remote link but we don't necessarily have to wait on that to merge. Also seeing issues with Travis' network again but I restarted the build so we'll see what happens. Latest this goes in is tomorrow. |
Ran all tests locally which only ran fine aside from the broken link from webpack-contrib/install-webpack-plugin#118. Doesn't make sense to hold this merge up just for that though. If anything else comes up we can resolve in a separate PR. @pierreneter I'll likely start working on #1519 soon, and will talk with @bebraw to try to simplify the antwar configuration even more. Will submit separate PRs for that and cc you. |
@pierreneter it's in 🎉 Thanks again for all of your work on finishing this off. It should definitely make it easier to keep pushing the repo forward in terms of build process and infrustructure. I will try to set up a discussion soon, maybe in slack or something, with those interested in the infrastructure of the site so we can make a solid plan. |
extends PR #980: I'm sure this is already known but the bug is happening because the left side is having its title put in a `p` tag whereas the right side is right _before_ its equivalent `p` tag :(. This seems to resolve the issue for now but the markup should be parsed properly.
Port site to webpack 3 and a new version of antwar that fixes a variety of bugs. What's left:
<title>
tags, none of which are populatedintroduction
sidebar linksResolves #720 (once titles are fixed, remember to double check vote title)