-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dev-server.md): Clarify the possible return value for devServer.… #3211
docs(dev-server.md): Clarify the possible return value for devServer.… #3211
Conversation
Preview is ready Built with commit 244d82f https://deploy-preview-3211--webpackjsorg-netlify.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi. Can someone merge the PR for me? Thanks. |
@randing89 could you please merge with the last master? |
@mistic done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting a small change to the text, a question on :void
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addressed all the suggestions
Thanks! |
Better align the docs with the code changes here: webpack/webpack-dev-server#1696 (comment)
The doc was ambiguous about what
false
return values does.