Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary #1242

Merged
merged 11 commits into from
May 27, 2017
Merged

Glossary #1242

merged 11 commits into from
May 27, 2017

Conversation

rouzbeh84
Copy link
Collaborator

@rouzbeh84 rouzbeh84 commented May 24, 2017

From #1223:

Building out base for glossary per #970. Definitely needs more items so help would be much appreciated in checking/adding glossary items 👍

Ditching forked repo and clearing up git index for clarity sake. Thanks to @skipjack!

Resolves #970

Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. This file lacks the YAML frontmatter (for defining its title). And you might want links to the glossary (e.g. in the menu)?

@skipjack skipjack mentioned this pull request May 26, 2017
@skipjack
Copy link
Collaborator

skipjack commented May 26, 2017

Added the frontmatter and a link to this page from the footer. @bebraw I also updated the cc-by license image to a slightly tighter one and pointed that to our /license page:

image

The other badge was causing some overflow and tightness on mobile.

If everyone's good with it (and if the build passes), I think we should merge this sucker and then maybe work on other pr(s) to start linking to this page from various articles... and obviously if anyone else comes up with other key terms that would be great as well.

@skipjack skipjack requested a review from bebraw May 27, 2017 19:21
@skipjack
Copy link
Collaborator

Ok let's merge, the build is only failing due to the fact that the edit link doesn't exist yet (but will once this is merged). If any issues slip in we can fix in a separate PR.

@skipjack skipjack merged commit 7709ba8 into master May 27, 2017
@skipjack skipjack deleted the glossary branch May 27, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants