Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to react-markdown loader list #1215

Merged
merged 2 commits into from
May 15, 2017
Merged

Add link to react-markdown loader list #1215

merged 2 commits into from
May 15, 2017

Conversation

fernandopasik
Copy link
Contributor

No description provided.

@fernandopasik fernandopasik changed the title docs(loaders): Add link to react-markdown loader Add link to react-markdown loader May 14, 2017
@fernandopasik fernandopasik changed the title Add link to react-markdown loader Add link to react-markdown loader list May 14, 2017
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandopasik that package looks cool, but are you sure it's a webpack loader? I just read through the readme and it looks like it's an isolated package (not necessarily used within webpack).

@fernandopasik
Copy link
Contributor Author

fernandopasik commented May 14, 2017

We developed for use only in webpack, it doesn't work as standalone.
We added it in the old site a while ago: https://webpack.github.io/docs/list-of-loaders.html#templating

@skipjack
Copy link
Collaborator

skipjack commented May 15, 2017

Is it a loader itself though, or just used in conjunction with the json-loader? Just to clarify, I'm not saying we can't include it somewhere in the documentation -- we love to promote useful tools in the webpack ecosystem -- I'm just not sure if the loaders' page is the best place.

@fernandopasik
Copy link
Contributor Author

Thanks for your help @skipjack! It is a loader itself, it's not used in conjunction with any other loader.
It's used with markdown files, all the content gets into a react component, and as a bonus if there is a react code block it gets also executed. It's ideal for building styleguides. That is why we added it in the previous webpack site in the templating loaders list.

@skipjack
Copy link
Collaborator

Ah I see, I was looking at the wrong package!

@skipjack skipjack merged commit b902d65 into webpack:master May 15, 2017
@fernandopasik
Copy link
Contributor Author

Thank you @skipjack !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants