-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect NODE_PATH
env variable
#4581
Conversation
Codecov ReportBase: 92.06% // Head: 92.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4581 +/- ##
==========================================
+ Coverage 92.06% 92.19% +0.12%
==========================================
Files 16 16
Lines 1639 1639
Branches 617 617
==========================================
+ Hits 1509 1511 +2
+ Misses 119 117 -2
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le't simprove this using:
if (typeof process.env.NODE_PATH !== undefined) {
// Logic
}
I think we need the same change in webpack-cli
and webpack
itself, can you fix it? thank you
hm, from docs:
And
Also paths on windows and linux are platform specific (and windows can has multiple paths separated by So I see two solutions here:
I am working on |
@snitin315 Found an easy solution, we should use it in |
Also it should be after |
Nice solution, I'll update in webpack/webpack-cli 👍🏻 |
For Bugs and Features; did you add new tests?
No.
Motivation / Use-Case
Porting changes from webpack/webpack-cli#3411
Reference webpack/webpack-cli#3355
Breaking Changes
No.
Additional Info
No.