-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use async API #3719
refactor: use async API #3719
Conversation
1ba7c4d
to
c82d089
Compare
5049d19
to
6b5ae94
Compare
38541d1
to
c0af5e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3719 +/- ##
==========================================
- Coverage 92.87% 92.59% -0.29%
==========================================
Files 14 14
Lines 1320 1323 +3
Branches 466 466
==========================================
- Hits 1226 1225 -1
- Misses 87 91 +4
Partials 7 7
Continue to review full report at Codecov.
|
In future we should avoid sync API in favor async where it possible |
Please note |
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
use async API
Breaking Changes
No
Additional Info
No