-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect the client.logging
option for HMR logging
#3159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
- Coverage 94.99% 94.93% -0.06%
==========================================
Files 37 38 +1
Lines 1218 1245 +27
Branches 338 346 +8
==========================================
+ Hits 1157 1182 +25
- Misses 55 57 +2
Partials 6 6
Continue to review full report at Codecov.
|
Will finish tomorrow, need improve client for |
@alexander-akait what is still in TODO here? |
WIP on tests, broken only on Node.js 10 due bug in |
Node 10 is about to reach its end of life 😞 |
Yep, but I think webpack-dev-server v4 will have short time, we should refactor it to plugin, I'll show you how to do it |
We will improve coverage after refactor |
For Bugs and Features; did you add new tests?
fixes #2946 fixes #2932
Motivation / Use-Case
Allow to disable extra logging from webpack
Breaking Changes
No
Additional Info
currentScript
parsingnew URL()
and Node.js legacy format