Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contentBase (static) logging #2744

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Conversation

ylemkimon
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A (covered by existing tests)

Motivation / Use-Case

contentBase has been removed in favor of static in #2670.

Breaking Changes

N/A

Additional Info

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #2744 (4f42e75) into v4 (5e90f25) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2744      +/-   ##
==========================================
+ Coverage   92.90%   93.04%   +0.14%     
==========================================
  Files          39       39              
  Lines        1310     1308       -2     
  Branches      351      348       -3     
==========================================
  Hits         1217     1217              
+ Misses         89       87       -2     
  Partials        4        4              
Impacted Files Coverage Δ
lib/utils/status.js 88.88% <100.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e90f25...4f42e75. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait alexander-akait merged commit 19b793f into webpack:v4 Nov 16, 2020
@alexander-akait
Copy link
Member

Thanks

@alexander-akait
Copy link
Member

Something else where you want to help?

@ylemkimon
Copy link
Contributor Author

@evilebottnawi Yes, please let me know where I can help.

@alexander-akait
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants