feat(server): async user callback for server.listen #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #2218 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 36 36
Lines 1302 1302
Branches 367 367
=======================================
Hits 1223 1223
Misses 70 70
Partials 9 9
Continue to review full report at Codecov.
|
hiroppy
reviewed
Aug 23, 2019
test/server/Server.test.js
Outdated
| const compiler = webpack(config); | ||
| const server = new Server( | ||
| compiler, | ||
| Object.assign( |
There was a problem hiding this comment.
nit
{
onListening: () => {
callOrder.push('onListening');
},
...baseDevConfig
}
jamesgeorge007
suggested changes
Sep 1, 2019
lib/Server.js
Outdated
| @@ -748,10 +748,10 @@ class Server { | |||
| // specifically so that things are done in the right order to prevent | |||
| // backwards compatability issues | |||
There was a problem hiding this comment.
Suggested change
| // backwards compatability issues | |
| // backwards compatibility issues |
knagaitsev
force-pushed
the
async-user-callback
branch
from
e7d37f4 to
133c3b5
Compare
hiroppy
approved these changes
Sep 24, 2019
hiroppy
pushed a commit
that referenced
this pull request
Dec 12, 2019
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
hiroppy
pushed a commit
that referenced
this pull request
Dec 18, 2019
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
hiroppy
pushed a commit
that referenced
this pull request
Dec 19, 2019
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
hiroppy
pushed a commit
that referenced
this pull request
Dec 23, 2019
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
hiroppy
pushed a commit
that referenced
this pull request
Dec 24, 2019
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
alexander-akait
pushed a commit
that referenced
this pull request
Jan 29, 2020
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
alexander-akait
pushed a commit
that referenced
this pull request
Jan 31, 2020
* feat(server): made user callback async, remove cli listen redundancy * test(server): added server listen method async callback tests * test(server): create options object using spread operator * chore(server): fix comment spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Not yet
Motivation / Use-Case
@evilebottnawi Is this what you meant by async
userCallback?Making the callback from
server.listenasync, along with the internally useduserCallback. Also, removed a redundant piece of code that I left in the CLI.Breaking Changes
None
Additional Info