chore(ci): add v8 and v11 of Node version #1652
Conversation
hiroppy
requested review from
alexander-akait and
michael-ciniawsky
as code owners
.travis.yml
Outdated
| @@ -20,9 +26,12 @@ jobs: | |||
| env: SCRIPT=test | |||
| # Node 10 instead of 'stable' since Node 11 segfaults | |||
There was a problem hiding this comment.
I would like to erase it if it is stable.
There was a problem hiding this comment.
@hiroppy let's remove comment and use node_js: 10, stable can be changed in future
There was a problem hiding this comment.
Also let's add node_js: 11
There was a problem hiding this comment.
Is it like this?(or we should use 'lts/*'?)
- &osx
stage: Test (MacOS)
os: 'osx'
env: SCRIPT=test
- <<: *osx
node_js: 11
- <<: *osx
node_js: 10
- <<: *osx
node_js: 8
- <<: *osx
node_js: 6
There was a problem hiding this comment.
👍 Let's avoid lts/* and stable, better use version directly
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 15 15
Lines 484 484
Branches 120 120
=======================================
Hits 399 399
Misses 68 68
Partials 17 17
Continue to review full report at Codecov.
|
Add node_modules as cache.
|
God job thanks! |
|
I'll try it:) |
and add node_modules as a cache
For Bugs and Features; did you add new tests?
Motivation / Use-Case
#1650 (comment)
Breaking Changes
no
Additional Info