fix(cli): throws err when no args passed #862

pranshuchittora · 2019-04-26T06:42:03Z

Closes #861
** Behaviour after fix **

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Nopes

trows an error when webpack is not installed and no args passed to the cli

fixed spacing issues

rishabh3112

Left a few suggestions! Thanks.

bin/cli.js

ematipico

I think there are two user cases:

webpack not installed and no args passed
webpack intalled and no args passed

bin/cli.js

tells user to install webpack in order for futher procedures

pranshuchittora · 2019-04-26T20:06:42Z

Progress so far:

Asks the user to install webpack if it's not been installed && no args passed.

Shows dynamic message based on package manager. (Default npm)

shows different error message based on package manager

…k-fix

EugeneHlushko

Looks like it works from the discussion, but code can be shaped better if you want to improve it

bin/cli.js

combined nested conditional blocks into one

EugeneHlushko · 2019-05-14T12:40:59Z

Yes thats what i meant, thank you for implementing 👍

fixed linting error

webpack-bot · 2019-05-14T13:36:55Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

rishabh3112

Looks great now, left a suggestion :)

bin/cli.js

pranshuchittora · 2019-05-18T20:30:26Z

Need help: Reason for failing CI

ematipico · 2019-05-22T08:50:29Z

Please rebase, we removed node 6 from the CI

…k-fix

bin/cli.js

…k-fix

webpack-bot · 2019-05-30T14:40:27Z

@pranshuchittora Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

modified the default stack trace limit and made cli to exit with exit code 1 when no args passed and webpack is not installed

bin/cli.js

removes the return statement from the catch block

…k-fix

removed the comment as per the suggestions by even

evenstensberg · 2019-06-01T05:53:36Z

bin/cli.js

@@ -70,6 +70,20 @@ For more information, see https://webpack.js.org/api/cli/.`);
 		try {
 			options = require("./utils/convert-argv")(argv);
 		} catch (err) {
+			if (err.code === "MODULE_NOT_FOUND") {
+				let errorMessage =
+					"\n\u001b[31mwebpack not found, \u001b[33mplease install webpack using\n\t\u001b[32mnpm install --save-dev webpack\n";


webpack not installed, consider installing it using npm install --save-dev webpack

Indentation seems weird here, you don't need different color schemes for the not found part, the please install part and the installation text. Two colors is sufficient, one for the error stack and one for the npm save

updates the err message

pranshuchittora · 2019-06-01T16:20:49Z

Some clarification regarding the return statement.

If the func won't return, then a frightening err message will logs out.

pranshuchittora · 2019-06-01T16:21:19Z

@evenstensberg pls review the final changes.
#ReadyToMerge

fixes the linting err

evenstensberg · 2019-06-01T16:22:31Z

Tests are failing, could you revise? Having a look now at how it's looking

evenstensberg

lgtm, do you mind fixing the eslint stuff? Other than that I think we're ready to merge

evenstensberg · 2019-06-01T16:27:58Z

bin/cli.js

+				console.error(errorMessage);
+				Error.stackTraceLimit = 1;
+				process.exitCode = 1;
+				return;


I guess this is fine, as long as we're doing it in the scope of only MODULE_NOT_FOUND

pranshuchittora added 2 commits April 26, 2019 11:47

fix(cli): error when no webpack and args found

2250af0

trows an error when webpack is not installed and no args passed to the cli

chore(cli): fixes code indentation

ff263f9

fixed spacing issues

webpack-bot added PR: unreviewed PR: small labels Apr 26, 2019

rishabh3112 requested changes Apr 26, 2019

View reviewed changes

bin/cli.js Outdated Show resolved Hide resolved

bin/cli.js Outdated Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 26, 2019

pranshuchittora mentioned this pull request Apr 26, 2019

🐞[cli]: throws err when no args passed. #861

Closed

ematipico reviewed Apr 26, 2019

View reviewed changes

bin/cli.js Outdated Show resolved Hide resolved

fix(cli): improves error handling with args

cc64955

tells user to install webpack in order for futher procedures

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Apr 26, 2019

pranshuchittora added 2 commits April 27, 2019 15:44

fix(cli): shows error message based on package manager

a3ce273

shows different error message based on package manager

Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…

8d1adfe

…k-fix

webpack-bot added the PR: CI-ok label May 4, 2019

EugeneHlushko reviewed May 9, 2019

View reviewed changes

bin/cli.js Outdated Show resolved Hide resolved

bin/cli.js Outdated Show resolved Hide resolved

fix(cli): err when no args passed, refactored nested conditional blocks

a9bc0bd

combined nested conditional blocks into one

webpack-bot added PR: CI-not-ok and removed PR: CI-ok labels May 14, 2019

fix(ci): fixes linting error in ci

cfc0117

fixed linting error

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels May 14, 2019

rishabh3112 requested changes May 15, 2019

View reviewed changes

bin/cli.js Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels May 15, 2019

Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…

3a034bf

…k-fix

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels May 22, 2019

evenstensberg closed this May 27, 2019

evenstensberg reopened this May 27, 2019

ematipico approved these changes May 27, 2019

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels May 27, 2019

evenstensberg reviewed May 29, 2019

View reviewed changes

bin/cli.js Show resolved Hide resolved

Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…

62e3c9e

…k-fix

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels May 30, 2019

fix(cli): sets stack trace limit

869024f

modified the default stack trace limit and made cli to exit with exit code 1 when no args passed and webpack is not installed

evenstensberg reviewed May 30, 2019

View reviewed changes

bin/cli.js Show resolved Hide resolved

evenstensberg reviewed May 30, 2019

View reviewed changes

bin/cli.js Outdated Show resolved Hide resolved

pranshuchittora added 3 commits May 31, 2019 00:01

fix(cli): removes func return in catch instance

7d31321

removes the return statement from the catch block

Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…

3d67892

…k-fix

fix(cli): removes the comment before err handling block

ac5a53f

removed the comment as per the suggestions by even

evenstensberg reviewed Jun 1, 2019

View reviewed changes

fix(cli): updates err message

b5e1913

updates the err message

chore(cli): fixes linting err

9f1deb2

fixes the linting err

evenstensberg approved these changes Jun 1, 2019

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jun 1, 2019

evenstensberg merged commit 6ee3c0b into webpack:master Jun 1, 2019

snyk-bot mentioned this pull request Sep 16, 2021

[Snyk] Fix for 1 vulnerabilities enterstudio/webpack-cli#21

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): throws err when no args passed #862

fix(cli): throws err when no args passed #862

pranshuchittora commented Apr 26, 2019

rishabh3112 left a comment

ematipico left a comment •

edited

Loading

pranshuchittora commented Apr 26, 2019 •

edited

Loading

EugeneHlushko left a comment

EugeneHlushko commented May 14, 2019

webpack-bot commented May 14, 2019

rishabh3112 left a comment

pranshuchittora commented May 18, 2019

ematipico commented May 22, 2019

webpack-bot commented May 30, 2019

evenstensberg Jun 1, 2019

evenstensberg Jun 1, 2019

pranshuchittora Jun 1, 2019

pranshuchittora commented Jun 1, 2019

pranshuchittora commented Jun 1, 2019

evenstensberg commented Jun 1, 2019

evenstensberg left a comment

evenstensberg Jun 1, 2019

fix(cli): throws err when no args passed #862

fix(cli): throws err when no args passed #862

Conversation

pranshuchittora commented Apr 26, 2019

rishabh3112 left a comment

Choose a reason for hiding this comment

ematipico left a comment • edited Loading

Choose a reason for hiding this comment

pranshuchittora commented Apr 26, 2019 • edited Loading

EugeneHlushko left a comment

Choose a reason for hiding this comment

EugeneHlushko commented May 14, 2019

webpack-bot commented May 14, 2019

rishabh3112 left a comment

Choose a reason for hiding this comment

pranshuchittora commented May 18, 2019

ematipico commented May 22, 2019

webpack-bot commented May 30, 2019

evenstensberg Jun 1, 2019

Choose a reason for hiding this comment

evenstensberg Jun 1, 2019

Choose a reason for hiding this comment

pranshuchittora Jun 1, 2019

Choose a reason for hiding this comment

pranshuchittora commented Jun 1, 2019

pranshuchittora commented Jun 1, 2019

evenstensberg commented Jun 1, 2019

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg Jun 1, 2019

Choose a reason for hiding this comment

ematipico left a comment •

edited

Loading

pranshuchittora commented Apr 26, 2019 •

edited

Loading