Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): fix ci #535

Merged
merged 3 commits into from
Jul 4, 2018
Merged

chore(build): fix ci #535

merged 3 commits into from
Jul 4, 2018

Conversation

dhruvdutt
Copy link
Member

@dhruvdutt dhruvdutt commented Jul 2, 2018 •
edited
Loading

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary
Fixed some linting issue but the tests are still failing due to some other issue (currently debugging)

Does this PR introduce a breaking change?

Other information

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Jul 2, 2018 •
edited
Loading

Needs investigation.

@dhruvdutt dhruvdutt changed the title chore(build): fix ci [WIP] - chore(build): fix ci Jul 2, 2018
@dhruvdutt dhruvdutt removed the request for review from evenstensberg July 2, 2018 17:53
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
Copy link
Member

What's the status on this?

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Jul 3, 2018 •
edited
Loading

What's the status on this?

Tests are breaking because of some change in yargs 12.
The changelog looks clean. Currently investigating the issue.

evenstensberg
evenstensberg approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks lgtm here, is this ready?

dhruvdutt
dhruvdutt commented Jul 4, 2018
View reviewed changes
Copy link
Member Author

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the changes in stdin looks good. The order of output has changed a little bit as now it's adding a line in between outputting the entrypoint file name.

Looks good to merge if the change in output order is acceptable.

@dhruvdutt dhruvdutt changed the title [WIP] - chore(build): fix ci chore(build): fix ci Jul 4, 2018
@evenstensberg evenstensberg merged commit 617af0b into webpack:master Jul 4, 2018
@dependencies dependencies bot mentioned this pull request Jul 23, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvdutt @webpack-bot @evenstensberg