Update eslint to the latest version 🚀 #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
|
|
evenstensberg
requested changes
Jun 23, 2018
There was a problem hiding this comment.
@dhruvdutt seems like package lock isn't working. Can you look at the package-lock PR / what is failing?
|
@greenkeeperio-bot Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
Version 5.0.1 just got published.Update to this version instead 🚀 Release Notesv5.0.1 |
ematipico
approved these changes
Jun 26, 2018
|
Seems like the linting for the tests folder is failing.Easy fix in a seperate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 5.0.0 of eslint was just published.
[eslint](https://github.com/eslint/eslint)The version 5.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of eslint.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
v5.0.0Release blogpost
Migration guide
Commits
The new version differs by 148 commits.
36ced0a5.0.05fd5632Build: changelog update for 5.0.00feedfdNew: Added max-lines-per-function rule (fixes #9842) (#10188)daefbdbUpgrade: eslint-scope and espree to 4.0.0 (refs #10458) (#10500)077358bDocs: no-process-exit: recommend process.exitCode (#10478)f93d6ffFix: do not fail on unknown operators from custom parsers (fixes #10475) (#10476)05343fdFix: add parens for yield statement (fixes #10432) (#10468)d477c5eFix: check destructuring for "no-shadow-restricted-names" (fixes #10467) (#10470)7a7580bUpdate: Add considerPropertyDescriptor option to func-name-matching (#9078)e0a0418Fix: crash on optional catch binding (#10429)de4dba9Docs: styling team members (#10460)5e453a3Docs: display team members in tables. (#10433)b1895ebDocs: Restore intentional spelling mistake (#10459)a9da57d5.0.0-rc.03ac3df6Build: changelog update for 5.0.0-rc.0There are 148 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴