Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): show help flag when defaults fail #466

Merged
merged 11 commits into from
Jun 2, 2018
Merged

fix(cli): show help flag when defaults fail #466

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2c9db31
fixed test cases
sumit-gupta91 May 8, 2018
4b50c34
remove unwanted console
sumit-gupta91 May 8, 2018
3c6a631
fix(254) - addressed PR comments
sumit-gupta91 May 21, 2018
0a89eb6
fix(254) - added requested changes at right place
sumit-gupta91 May 21, 2018
904e527
fix(254) - exit after error
sumit-gupta91 May 22, 2018
5c9fe7c
fix: require chalk
sumit-gupta91 May 27, 2018
bac9c01
refactor - addressed PR comments
sumit-gupta91 May 30, 2018
c604d3e
refactor - addressed PR comments
sumit-gupta91 May 31, 2018
1bc3318
refactor : remove unwanted keywords
sumit-gupta91 May 31, 2018
94579b7
chore(review): format
evenstensberg Jun 2, 2018
26d7f8c
Merge branch 'next' into bugfix/error-message
evenstensberg Jun 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,17 @@ For more information, see https://webpack.js.org/api/cli/.`);
);
} else if (stats.hash !== lastHash) {
lastHash = stats.hash;
if (stats.compilation && stats.compilation.errors.length !== 0) {
const errors = stats.compilation.errors;
if (errors[0].name === "EntryModuleNotFoundError") {
stdout.write("\n" + errors[0].error.toString() + "\n");
stdout.write(
"\n" + "ERROR Insufficient number of arguments provided " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove error and info. Let's have this format:

Can't resolve.... Insufficient args.

alternatively run webpack...

"\n" + "INFO Alternatively, run `webpack(-cli) --help` for usage info." +
"\n\n"
);
}
}
const statsString = stats.toString(outputOptions);
const delimiter = outputOptions.buildDelimiter
? `${outputOptions.buildDelimiter}\n`
Expand Down
10 changes: 3 additions & 7 deletions test/binCases/no-options/development/stdin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
"use strict";

module.exports = function testAssertions(code, stdout, stderr) {
expect(code).toBe(2);
expect(code).toBe(0);
expect(stdout).toEqual(expect.anything());
expect(stdout[0]).toContain("Hash: ");
expect(stdout[1]).toContain("Version: ");
expect(stdout[2]).toContain("Time: ");
expect(stdout[4]).toContain("");
expect(stdout[5]).toContain("ERROR in Entry module not found");
expect(stdout[6]).toContain("");
expect(stdout[3]).toContain("Insufficient number of arguments provided");
expect(stdout[4]).toContain("Alternatively, run `webpack(-cli) --help` for usage info");
expect(stderr).toHaveLength(0);
};
13 changes: 3 additions & 10 deletions test/binCases/no-options/none/stdin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
"use strict";

module.exports = function testAssertions(code, stdout, stderr) {
expect(code).toBe(2);
expect(code).toBe(0);
expect(stdout).toEqual(expect.anything());
expect(stdout[0]).toContain("Hash: ");
expect(stdout[1]).toContain("Version: ");
expect(stdout[2]).toContain("Time: ");
expect(stdout[4]).toContain("");
expect(stdout[5]).toContain("WARNING");
expect(stdout[6]).toContain("The \'mode\' option has not been set");
expect(stdout[7]).toContain("You can also set it to \'none\'");
expect(stdout[8]).toContain("");
expect(stdout[9]).toContain("ERROR in Entry module not found");
expect(stdout[3]).toContain("Insufficient number of arguments provided");
expect(stdout[4]).toContain("Alternatively, run `webpack(-cli) --help` for usage info");
expect(stderr).toHaveLength(0);
};
10 changes: 3 additions & 7 deletions test/binCases/no-options/production/stdin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
"use strict";

module.exports = function testAssertions(code, stdout, stderr) {
expect(code).toBe(2);
expect(code).toBe(0);
expect(stdout).toEqual(expect.anything());
expect(stdout[0]).toContain("Hash: ");
expect(stdout[1]).toContain("Version: ");
expect(stdout[2]).toContain("Time: ");
expect(stdout[4]).toContain("");
expect(stdout[5]).toContain("ERROR in Entry module not found");
expect(stdout[6]).toContain("");
expect(stdout[3]).toContain("Insufficient number of arguments provided");
expect(stdout[4]).toContain("Alternatively, run `webpack(-cli) --help` for usage info");
expect(stderr).toHaveLength(0);
};
5 changes: 5 additions & 0 deletions test/binCases/no-options/stdin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"use strict";

module.exports = function testAssertions(code, stdout, stderr) {
expect(stdout[3]).toContain("Insufficient number of arguments provided");
};