Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add examples for single and multiple entries prompt (#162) #167

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

avivr
Copy link
Contributor

@avivr avivr commented Jun 25, 2017

What kind of change does this PR introduce?

Add example when prompting for single / multiple entries.

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary

Address issue #162

Does this PR introduce a breaking change?

No

Other information
Sample screenshot -
screen shot 2017-06-25 at 23 33 16

@avivr
Copy link
Contributor Author

avivr commented Jun 25, 2017

btw, I followed the instrcutions on the CONTRIBUTING.md 'Setup' section and installed the commit validator but then I couldn't commit at all.
Got the following error:

ERR! Error Commit message invalid
ERR! Error[tags]: You used 0 tag(s) in your commit message. Use only 1.

The commit message was "feat: add examples for single and multiple entries prompt (#162)", which seems to me align with the commit format. What am I missing?

I couldn't find what was wrong with the commit message so I had to execute fit-commit-js uninstall to remove the git-hook and be able to commit.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM , @okonet 2nd review and answer comment

@DanielaValero
Copy link
Contributor

Hi @avivr The commit validator has a bug, I'll migrate it to comitizen soon and update the setup instructions.

@evenstensberg
Copy link
Member

Guess we can merge this though? @DanielaValero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants