Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-cli): add --no-hot flag #1591

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
added --no-hot flag.

Refers #1240 #717
Fixes #1296

Does this PR introduce a breaking change?
Yes

Other information

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need improve tests

test/no-hot/no-hot.test.js Show resolved Hide resolved
alexander-akait
alexander-akait previously approved these changes Jun 1, 2020
rishabh3112
rishabh3112 previously approved these changes Jun 3, 2020
anshumanv
anshumanv previously approved these changes Jun 3, 2020
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions.

test/no-hot/no-hot.test.js Outdated Show resolved Hide resolved
test/serve/with-custom-port/serve-custom-config.test.js Outdated Show resolved Hide resolved
Co-authored-by: James George <jamesgeorge998001@gmail.com>
@snitin315 snitin315 dismissed stale reviews from anshumanv and rishabh3112 via 8940239 June 3, 2020 05:35
@snitin315 snitin315 reopened this Jun 3, 2020
@snitin315 snitin315 closed this Jun 3, 2020
@snitin315 snitin315 reopened this Jun 3, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@snitin315
Copy link
Member Author

/cc @jamesgeorge007 @rishabh3112

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@alexander-akait alexander-akait merged commit 31fcaf3 into webpack:next Jun 9, 2020
@snitin315 snitin315 deleted the feat/no-hot-flag branch June 14, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants