Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: peer dependencies for webpack serve #1317

Merged
merged 5 commits into from
Mar 23, 2020
Merged

fix: peer dependencies for webpack serve #1317

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
057de96
fix: peer dependencies for `webpack serve`
alexander-akait Mar 11, 2020
eeec9ea
chore: add webpack-dev-server to devDependencies
Mar 20, 2020
8f17d68
Merge branch 'next' into fix-peer-dependencies
ryanclark Mar 20, 2020
f5bf3db
chore: remove inquirer as it isn't used
Mar 20, 2020
6e49049
chore: remove other unused dependencies
Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/serve/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,18 @@
"dependencies": {
"@webpack-cli/utils": "^1.0.1-alpha.5",
"chalk": "3.0.0",
"cross-spawn": "6.0.5",
"inquirer": "6.5.1",
"webpack-cli": "^4.0.0-beta.8",
"webpack-dev-server": "^3.9.0"
"cross-spawn": "6.0.5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, where we use cross-spawn in out code? Maybe it should be dev dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place I see it used in the repo is part of the package-utils library

},
"devDependencies": {
"@types/cross-spawn": "6.0.0",
"@types/inquirer": "6.5.0",
"@types/node": "12.7.2",
"typescript": "3.5.3"
"typescript": "3.5.3",
"webpack-dev-server": "3.10.3"
},
"peerDependencies": {
"webpack-dev-server": ">=3.0.0"
},
"peerDependenciesMeta": {
"webpack-dev-server": {
"optional": false
}
"webpack-cli": "4.x.x",
"webpack-dev-server": "3.x.x || 4.x.x"
},
"scripts": {
"build": "tsc",
Expand Down