-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests #116
Merged
evenstensberg
merged 9 commits into
webpack:feature/init-ast
from
kalcifer:init-ast/tests
Apr 18, 2017
Merged
Add more tests #116
evenstensberg
merged 9 commits into
webpack:feature/init-ast
from
kalcifer:init-ast/tests
Apr 18, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksjce
commented
Apr 17, 2017
aggregateTimeout: 300, | ||
poll: 1000, | ||
ignored: /node_modules/ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test case
evenstensberg
added a commit
that referenced
this pull request
May 7, 2017
* feat: initial commit on last structure and transforms * feat: ast for entry * feat: ast for output * feat: ast for context * feat: work in progress on resolve * feat: add transform structure for all * fix: remove rx from the project * fix: return ast on no prop at resolve * feat: ast for resolve * feat: ast for devtool * feat: art for target * feat: ast for watch * feat: sat for watchOptions * fix: rename dev-tool to devtool * feat: ast for externals * feat: ast for node * feat: sat for performance * feat: ast for stats * feat: ast for other * feat: allow multiple packages in CLI command * feat: allow dynamic entry points * feat: allow promises as entry points * feat: function decl for resolve.cachePredictate * feat: allow function for performance.assetFilter * feat: allow regex and functions in external prop * feat: regexp for outputPrefix * feat: use property without strings * feat: allow regex for unsafeCache * feat: ast for module * feat: ast for plugins * feat: art for paths * feat: prettier, topScope and runtime flow Adds the runtime flow, with prettier as well as some fixes to transformations + a top scope transformation. * feat: ast for cache * feat: module regexp fix * feat: fix generator methods * chore: bump add ons dep * feat: introduce scaffold for external runs * feat: don't use jscodeshift to parse unknown values * feat: allow name conventions * feat: allow multiple config creations * feat: allow using inject for resolve and module * feat: allow merge in scaffold * fix: make build more readable * feat: add HOC to each transform * feat: find correct folder for packages * fix: example transform in generator and fix to path * Add your first test (#114) * Tests for entry.js (#115) * Add failing test * Pass the test on entry with array and update snapshots * If entry is an object * Add failing test case for externals * Fix bug with externals regexp * fix: add identifier creation and fix entry tests * Add more tests (#116) * Test watch transform * Test watch transform (Doesnt look for existing obj) * Test target transform (Doesnt look for existing obj) * Test plugins transform (Doesnt look for existing obj) * Add failing test case for node * Add test case for node * Add first instance of duplicate check and override * Extract a function * Make a util to override object params * Cleanup the ast branch transformation (#117) * refactor watch options * refactor target * refactor context * refactor devtool * refactor node * refactor plugins * refactor amd * refactor bail * Moar tests * feat: add new tests for entry & regex for validateOptions * feat: more tests for obj ref Adds more tests to object references and the context transform * fix: fix devtool property and add tests for it * add externals test and fix identifier util Adds tests to externals, some fixes to the externals transform as well as a fix to utils, where it becomes a literal despite being an identifier. * feat: add test to array with obj reference in ext * fix: fix silly mistake on devtools props Sorry Pavithra.. * tests: add tests for every transform * feat: add more utility for tests * enhancements: use abstractions & utils * utils: add regex util * chore: add JSdocs to each transform * enhancements: use more utility on transforms * enhancements: use createpushval for all transforms * enhancements: use new utility to create single properties * enhancements: add test for utility functions * fix: don't use await for promise * enhancements: send each transform object to respective transform * enhancements: remove createsingular Replaced by pushCreateProperty * enhancements: use more utility and remove boilerplate code * chore: remove fixme flag * chore: prettify ast.find * enhancements: use objKey util for entry and externals * enhancements: use utility on resolve * enhancements: fix merge & utilize module folder * enhancements: use prettier node API * fix: don't print success msg more than one time * enhancements: fix windows paths * Webpack-CLI Documentation (#112) * chore: init * chore: add section about init and migrate * chore: add migrate and scaffold link * Create SCAFFOLDING.md * Create MIGRATE.md * chore: add docs on scaffolding * chore: add initial on addons * chore: fix initial documentation Also fixes some text at «Scaffolding» * chore: revise section on good scaffold * chore: add some API docs * chore: rephrase docs * chore: syntax sugar * chore: more syntax sugar * chore: lint webpack-cli properly * chore: prepare to update webpack/bin to ours * chore: refactor against webpack/lib * remove shebang * chore: remove old rx code * enhancements: default generator and exitCode Introduces a default generator and swapped exitCode(0) with exitCode = * chore: update addons pkg and reformat extractAnswer * enhancements: better bin resolves & default generator Thanks to Sindre Sorhus & Addy Osmani for the review. Fixed some better resolves in bin folder, removed some code in default generator to better scaffold for beginners. * enhancements: use validation to force answers * enhancements: check identifiers with properties * enhancements: revise anti pattern for promise Thanks to Sindre Sørhus for this fix. Object references are now making sure our callbacks are held, and removed the return of the promise and rather used the object we want to return. * enhancements: rename write to type and split params to newline * enhancements: add better scaffold to generator * enhancements: make default generator more User Friendly * enhancements: ask if user wants to make the config at end * enhancements: make default generator better * enhancements: add styling option to generator * fix: remove sourceMap from postcss prop * enhancements: separate dev and prod build * enhancements: add contentHash & name * enhancements: prompt for better answers * fix: remove unused module * chore: final fixes before release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.