-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect NODE_PATH
env variable
#3411
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #3411 +/- ##
==========================================
- Coverage 94.91% 91.74% -3.17%
==========================================
Files 30 22 -8
Lines 1690 1587 -103
Branches 492 447 -45
==========================================
- Hits 1604 1456 -148
- Misses 86 131 +45
Continue to review full report at Codecov.
|
98c2e0f
to
bc19031
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when CI will be green
bc19031
to
05f5c9d
Compare
Rebased. |
Something wrong on CI, debugging. |
Weird
|
On windows CI NODE_PATH is somehow defined. |
f2f05df
to
1524ec2
Compare
1f5d53a
to
415373e
Compare
@alexander-akait fixed, I moved the check outside of the loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good too, but can we add test case?
And let's add the check |
@snitin315 Can you send the same PR for |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No.
If relevant, did you update the documentation?
No.
Summary
Fix #3355
Does this PR introduce a breaking change?
No.
Other information
No