Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Revise README #327

Closed
evenstensberg opened this issue Mar 9, 2018 · 2 comments
Closed

Documentation: Revise README #327

evenstensberg opened this issue Mar 9, 2018 · 2 comments
Labels
Documentation Good First Contribution Help Wanted

Comments

@evenstensberg
Copy link
Member

What is the current behavior?
The README.md says:

For the time being, it is backwards-compatible with the CLI included in webpack itself.

The old CLI is removed in webpack, so that's inconsistent.

What is the expected behavior?
You can either revise the comment to say that the old CLI arguments is kept, or remove the line (preferable).

Important

This ticket is limited to first-time contributors only
@dhruvdutt
Copy link
Member

dhruvdutt commented Mar 9, 2018 •
edited
Loading

I would have qualified a couple of weeks ago. 😄
@Symphoria you wanna take a crack at this?

@bitpshr bitpshr mentioned this issue Mar 9, 2018
Merged
@bitpshr
Copy link
Member

bitpshr commented Mar 9, 2018

Happened to be looking at the Good First Contribution label a few minutes after this issue was created, so I grabbed it.

evenstensberg pushed a commit that referenced this issue Mar 10, 2018
@bitpshr @evenstensberg
docs: update README to remove inconsistent CLI messaging (#327) (#328)
6f7038a
This was referenced Mar 14, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Good First Contribution Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bitpshr @dhruvdutt @evenstensberg