Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate hints #100

Merged
merged 2 commits into from
May 18, 2020
Merged

feat: separate hints #100

merged 2 commits into from
May 18, 2020

Conversation

vankop
Copy link
Member

@vankop vankop commented May 15, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

partial #61

  • moved hints in separated util
  • added not logic support in hints
  • added test for hints

Breaking Changes

No

@evilebottnawi we can merge this in dev-1, if you don't want to merge partial feature (not logic support)

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #100 into master will decrease coverage by 0.17%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   98.12%   97.95%   -0.18%     
==========================================
  Files           5        6       +1     
  Lines         640      683      +43     
  Branches      267      284      +17     
==========================================
+ Hits          628      669      +41     
- Misses         12       13       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/validate.js 100.00% <ø> (ø)
src/ValidationError.js 97.38% <75.00%> (-0.28%) ⬇️
src/util/hints.js 98.27% <98.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bfe21...8649c10. Read the comment docs.

@vankop
Copy link
Member Author

vankop commented May 15, 2020

npm audit is annoying, did not find a way to fix it..

@alexander-akait
Copy link
Member

@vankop just ignore it 👍

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, one note

@alexander-akait alexander-akait merged commit a36e535 into webpack:master May 18, 2020
@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants