This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
feat: add support for ServiceWorker (options.mode)
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
force-pushed
the
feat-mode-service
branch
2 times, most recently
from
f826ddf
to
b144892
Compare
TrySound
reviewed
Oct 14, 2017
| @@ -4,6 +4,9 @@ | |||
| "name": { | |||
| "type": "string" | |||
| }, | |||
| "mode": { | |||
| "type": "string" | |||
There was a problem hiding this comment.
Can't we specify enumeration here?
There was a problem hiding this comment.
Yep, I think so will do (need to look it up again first 😛 ). Otherwise needs to throw in the code
michael-ciniawsky
force-pushed
the
feat-mode
branch
from
261f7f2
to
f5a64cc
Compare
michael-ciniawsky
force-pushed
the
feat-mode-service
branch
from
b144892
to
921ffb5
Compare
michael-ciniawsky
force-pushed
the
feat-mode-service
branch
from
921ffb5
to
7e49947
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteable ChangesAdds
ServiceWorkersupportIssuesServiceWorker#11ServiceWorkers#14Blocked bywebpack-defaults#81SharedWorker(options.mode) #98