This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
Revert "Use ES6 import in TypeScript README example" #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #140
This syntax causes TypeScript to output incorrect code. worker-loader creates a module like the following:
To describe this module in TypeScript you would use
and to import it you use
This is how I originally wrote the docs. The change assumes that worker-loader uses a module of the form
and emitted code will attempt to reference the
default
property of the module, resulting in aTypeError
whenever you try to use the module (since the property is undefined).TypeScript doc reference: https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require