Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.

refactor(loader) v2.0.0 #113

Merged
merged 12 commits into from
Apr 6, 2018
Merged

refactor(loader) v2.0.0 #113

merged 12 commits into from
Apr 6, 2018

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 5, 2017

  • Fixes for Webpack 4.x
  • Drops support for NodeJS 4.x
  • Sets minimum peerDep to Webpack 3.x

BREAKING CHANGE: Sets engines to "node": ">= 6.9.0 || >= 8.9.0"
BREAKING CHANGE: Drops support for Webpack v2.x

@joshwiens joshwiens changed the title [WIP] Worker Loader v2 [WIP] Worker Loader Webpack 4.x compatibility Dec 5, 2017
@webpack-contrib webpack-contrib deleted a comment from codecov bot Dec 5, 2017
@ooflorent
Copy link
Contributor

Some targets are no longer available in webpack 4:

  • atom
  • electron

@michael-ciniawsky michael-ciniawsky changed the title [WIP] Worker Loader Webpack 4.x compatibility [WIP] refactor(loader) v2.0.0 Jan 23, 2018
@michael-ciniawsky michael-ciniawsky added this to the 2.0.0 milestone Jan 23, 2018
@ooflorent
Copy link
Contributor

I've open a PR (webpack/webpack#6368) to expose the required internal plugins. In v2, you should drop the hot-linking of internal dependencies. This may prevent having a build step on webpack.

@switz
Copy link

switz commented Mar 28, 2018

Checking in on when we can merge this and #121

@benpoulson
Copy link

Really could do with this merge going ahead. Holding my team back from moving to Webpack 4.X.

@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4f7a931). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #113   +/-   ##
=========================================
  Coverage          ?   66.21%           
=========================================
  Files             ?        5           
  Lines             ?       74           
  Branches          ?       25           
=========================================
  Hits              ?       49           
  Misses            ?       22           
  Partials          ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7a931...fa94f58. Read the comment docs.

@shellscape shellscape changed the title [WIP] refactor(loader) v2.0.0 refactor(loader) v2.0.0 Apr 6, 2018
@shellscape shellscape merged commit c4c00e5 into master Apr 6, 2018
@alexander-akait alexander-akait deleted the next branch July 28, 2020 16:02
TheLD6978 pushed a commit to TheLD6978/worker-loader that referenced this pull request Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants