-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw FoamTree labels also during animation #414
Draw FoamTree labels also during animation #414
Conversation
… smooth on recent hardware. (cherry picked from commit 17716db)
Thanks! Would you be able to showcase the difference in behavior with a small screencap or something? It would make it easier to understand how this behavior has changed now |
Before: labels-during-zooming-before.mp4After: labels-during-zooming-after.mp4 |
Ooh neat! Thanks for the video, this helps me understand this change a lot better Would you be able to write a small changelog entry about this change? |
I'm not sure about this change as it may make a significant negative impact on the rendering performance during the animation for the large bundles especially on high-dpi screens e.g. retina. |
Actually, the zooming animation is rendered with pixelRatio=1. On High-DPI screens you should see a faded switch between the low- and high-resolution rendering before and after the animation. Additionally, when the number of groups is large, FoamTree does not render labels if their on-screen size is smaller than a threshold. The labels render only when the label size increases as a result of zooming. I was thinking of adding a configuration checkbox that would enable/disable labels during zooming, but then decided the gain may not be worth cluttering the UI. Ultimately, it's a matter of testing the performance on typical developer configurations. The no-labels zoom is a default that dates back to the first versions of FoamTree released nearly 10 years ago. The hardware has progressed a lot since then, so it may be a good moment to rethink this behaviour :-) |
Ok, I've checked that and looks like the rendering slowdown is acceptable. Could you fix a conflict in changelog please? |
Thanks! |
This should improve the user experience and should still be fairly smooth on recent hardware.