Replace express with builtin node server #398
Conversation
TrySound
force-pushed
the
drop-express
branch
from
a78b7a7 to
22a92f8
Compare
Alternative to long-standing webpack-contrib#212 Express in this project does not add much value. Middleware api is not necessary for 1.5 middlwares. We can try to use node server directly. Serving static is left for express middleware. Can be replaced with something smaller in another PR.
TrySound
force-pushed
the
drop-express
branch
from
22a92f8 to
4a674c4
Compare
src/viewer.js
Outdated
| @@ -13,6 +12,7 @@ const {open} = require('./utils'); | |||
| const {renderViewer} = require('./template'); | |||
|
|
|||
| const projectRoot = path.resolve(__dirname, '..'); | |||
| const viewsRoot = path.join(projectRoot, 'views'); | |||
There was a problem hiding this comment.
This line is not needed (merge artefact)
package.json
Outdated
| "filesize": "^6.1.0", | ||
| "gzip-size": "^6.0.0", | ||
| "lodash": "^4.17.20", | ||
| "opener": "^1.5.2", | ||
| "serve-static": "^1.14.1", |
There was a problem hiding this comment.
Seems like as per this comment:
serve-static is a big reason why express is so large so if polka would work for our use case, it's much smaller than using serve-static.
There was a problem hiding this comment.
Oh, that other PR uses sirv for the static serving?
There was a problem hiding this comment.
Well, if you are ok to introduce sirv I will use it. I just remember there was a doubt to introduce polka packages.
There was a problem hiding this comment.
Oh, I don't really know what opinion @th0r has 😅 — sorry for being unclear. If things work then the size differences this provides might be useful?
As long as the server is still able to show new results when a bundle is changed like was the purpose behind introducing this feature back in #74 then I would be OK with this change.
I think the supported node versions are good enough, too, and we don't accidentally regress from supporting node v10.13.0
There was a problem hiding this comment.
To support watch I passed "dev" flag which prevents caching.
I guess the size will be almost the same but without more polka dependencies.
#212 (comment)
There was a problem hiding this comment.
The serve-static is still in dependencies so I don't know how to figure out the size difference yet — some numbers on how this potentially affects the size of node_modules would be nice.
There was a problem hiding this comment.
https://packagephobia.com/result?p=static-serve
https://packagephobia.com/result?p=express (depends on static-serve out of the box)
https://packagephobia.com/result?p=sirv
https://packagephobia.com/result?p=polka (does not include sirv out of the box)
https://packagephobia.com/result?p=%40polka%2Furl (dependency of both sirv and polka)
There was a problem hiding this comment.
Why do we need serve-static if you decided to use sirv instead?
package.json
Outdated
| "filesize": "^6.1.0", | ||
| "gzip-size": "^6.0.0", | ||
| "lodash": "^4.17.20", | ||
| "opener": "^1.5.2", | ||
| "serve-static": "^1.14.1", |
There was a problem hiding this comment.
Why do we need serve-static if you decided to use sirv instead?
Alternative to long-standing #212
Express in this project does not add much value. Middleware api is not
necessary for 1.5 middlwares. We can try to use node server directly.
Serving static is left for express middleware. Can be replaced with
something smaller in another PR.
Thanks to @realityking for inspiration