Add tests for webpack4 modules with additional entrypoint ids

webpack-contrib · Mar 1, 2018 · f51c134 · f51c134
1 parent 1992efa
commit f51c134
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/parseUtils.js b/src/parseUtils.js
@@ -72,7 +72,7 @@ function parseBundle(bundlePath) {
         }
 
         // Additional bundles with webpack 4 are loaded with:
-        // (window.webpackJsonp=window.webpackJsonp||[]).push([[minimum ID], <module>, <module>]);
+        // (window.webpackJsonp=window.webpackJsonp||[]).push([[chunkId], [<module>, <module>], [[optional_entries]]]);
         if (
           isWindowPropertyPushExpression(node) &&
           args.length === 1 &&
@@ -129,6 +129,7 @@ function isArgumentContainsModulesList(arg) {
 function isArgumentContainingChunkIdsAndModulesList(arg) {
   if (
     arg.type === 'ArrayExpression' &&
+    arg.elements.length >= 2 &&
     isArgumentContainsChunkIds(arg.elements[0]) &&
     isArgumentContainsModulesList(arg.elements[1])
   ) {

diff --git a/test/bundles/validWebpack4ChunkAndEntryPoint.js b/test/bundles/validWebpack4ChunkAndEntryPoint.js
@@ -0,0 +1 @@
+(window.webpackJsonp=window.webpackJsonp||[]).push([[27],{"57iH":function(e,n,t){console.log("hello world")}},[["57iH",19,24,25]]]);
diff --git a/test/bundles/validWebpack4ChunkAndEntryPoint.modules.json b/test/bundles/validWebpack4ChunkAndEntryPoint.modules.json
@@ -0,0 +1,5 @@
+{
+  "modules": {
+    "57iH": "function(e,n,t){console.log(\"hello world\")}"
+  }
+}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		(window.webpackJsonp=window.webpackJsonp\|\|[]).push([[27],{"57iH":function(e,n,t){console.log("hello world")}},[["57iH",19,24,25]]]);