This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
feat: ensure unique usage #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulkish
force-pushed
the
hulkish-ForceUniqueUsage
branch
from
4995ddf to
214e65e
Compare
src/index.js
Outdated
| @@ -149,7 +149,10 @@ class UglifyJsPlugin { | |||
| } | |||
|
|
|||
| apply(compiler) { | |||
| const requestShortener = new RequestShortener(compiler.context); | |||
| if (UglifyJsPlugin.appliedCompilers.has(compiler)) return; | |||
There was a problem hiding this comment.
Maybe print a warning to notify users to check their setup nevertheless
return this.emitWarning(`
⚠️ UglifyJS Plugin\n
The plugin seems to be applied mutliple times, this can slow down your build times significantly.
Please check your `webpack.config.js`. Did you use 'webpack -p' and added the plugin manually?
`)Wording can be improved of course :)
I this there no 'simpler' way in achieving this ? 🙃
src/index.js
Outdated
| @@ -280,4 +283,11 @@ class UglifyJsPlugin { | |||
| } | |||
| } | |||
|
|
|||
| Object.defineProperty(UglifyJsPlugin, 'appliedCompilers', { | |||
There was a problem hiding this comment.
Whats the difference between
Object.defineProperty(UglifyJSPlugin. 'appliedCompilers', {...})&&
UglifyJSPlugin.appliedCompliers = new WeakSet()?
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`compiler plugin count 1`] = ` | ||
| Object { |
There was a problem hiding this comment.
Is this the compiler {Object} ?
michael-ciniawsky
added
pr_action: Rebase
status: Pending
semver: Minor
and removed
pr_action: Discuss
status: Needs triage
semver: Patch
labels
hulkish
force-pushed
the
hulkish-ForceUniqueUsage
branch
from
214e65e to
e1ae04a
Compare
hulkish
force-pushed
the
hulkish-ForceUniqueUsage
branch
from
e1ae04a to
aa026d5
Compare
michael-ciniawsky
added
status: Declined
and removed
flag: Performance
priority: 4 (important)
pr_action: Rebase
status: Pending
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72