Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

docs(README): Restore deleted note about uglify-js version handling (peerDependency) #106

Closed
wants to merge 1 commit into from

Conversation

alcuadrado
Copy link

Hi,

PR #61 deleted this sentence from the README which was really helpful. I found it by chance looking at tag v4.6's README.md while trying to use uglify-es with webpack. I suspect it was removed by accident, as it stated very clearly why one would use this package.

PR #61 deleted this sentence from the README which was really helpful.
@jsf-clabot
Copy link

jsf-clabot commented Aug 7, 2017

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky
Copy link
Member

The README on master refers to to the current beta and there is also a link to the v0.4.6 docs. This info doesn't apply for v1.0.0 and is incorrect for >= v0.4.6 aswell, which ships with a fixed version of uglify-js to avoid breaking the webpack build

@michael-ciniawsky michael-ciniawsky changed the title Restore deleted documentation docs(README): Restore deleted note about uglify-js version handling (peerDependency) Aug 7, 2017
@alcuadrado
Copy link
Author

Ohh, I see! I misunderstood the comment in v0.4.6. Sorry for the inconvenience!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants