Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Commit

Permalink
README: fix grammatical error (#29)
Browse files Browse the repository at this point in the history
  • Loading branch information
@piperchester @bebraw
piperchester authored and bebraw committed May 10, 2017
1 parent c253e14 commit 6eee9be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ With npm:
npm install uglifyjs-webpack-plugin --save-dev
```

**Important!** The plugin has a peer dependency to uglify-js, so in order to use the plugin, also uglify-js has to be installed. The currently (2017/1/25) available uglify-js npm packages, however, do not support minification of ES6 code. In order to support ES6, an ES6-capable, a.k.a. _harmony_, version of UglifyJS has to be provided.
**Important!** The plugin has a peer dependency to uglify-js, so in order to use the plugin, also uglify-js has to be installed. The currently (2017/1/25) available uglify-js npm packages; however, do not support minification of ES6 code. In order to support ES6, an ES6-capable, a.k.a. _harmony_, version of UglifyJS has to be provided.

If your minification target is ES6:

Expand Down

4 comments on commit 6eee9be

@nakamorichi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bebraw Why are we having this kind of useless commits where someone changes comma to semicolon? I don't even think there's a grammatical reason to do so.

@bebraw
Copy link
Contributor

@bebraw bebraw commented on 6eee9be May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a tiny commit, yeah. I just merge and forget small ones before moving onto next problem.

@nakamorichi
Copy link
Contributor

@nakamorichi nakamorichi commented on 6eee9be May 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this guy's profile and couldn't find a single functionally meaningful commit, but only huge number of commits similar to the above one, to numerous popular open source projects. Not that fixing typos is bad, but somehow I get the feeling that someone is either pathological grammar n-zi, or trying to get a job by seeming like active open source contributor without actually contributing anything meaningful. :D

@bebraw
Copy link
Contributor

@bebraw bebraw commented on 6eee9be May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, yeah.

Please sign in to comment.