Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): avoud using clona for stylus options #394

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Better perf and less deps

Breaking Changes

No

Additional Info

Added test which allow to override source map options, I think we need to implement this for other CSS like loaders, but it will be separately

@@ -249,15 +249,15 @@ describe("loader", () => {
const testId = "./shallow-deep-literal.styl";
const compiler = getCompiler(testId, {
stylusOptions: {
dest: "deep/deep-literal.css",
dest: path.resolve(__dirname, "fixtures/"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect after fixing logic, because developer can pass own options for source maps, we need to allow to change it too

@alexander-akait alexander-akait merged commit 261f70e into master Jun 8, 2023
@alexander-akait alexander-akait deleted the fix-perf-avoid-using-klona branch June 8, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant