Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress: false is ignored in production #302

Closed
wants to merge 2 commits into from

Conversation

phaistonian
Copy link

@phaistonian phaistonian commented Jan 13, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

When setting compress: false in production mode, this setting is ignored.

Breaking Changes

Additional Info

A better check is needed to ensure that `compress: false` is respected.
compress: false is ignored in production
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #302 (94c849e) into master (86a0ee0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files           3        3           
  Lines         349      349           
  Branches      107      107           
=======================================
  Hits          335      335           
  Misses         13       13           
  Partials        1        1           
Impacted Files Coverage Δ
src/utils.js 96.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a0ee0...94c849e. Read the comment docs.

@alexander-akait
Copy link
Member

Can you accept CLA?

@alexander-akait
Copy link
Member

I resent PR with tests, because I have twitter DM about fixing it ASAP from one company, anyway thanks for found this issue and send a PR, I am glad that you help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants