Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addStyles): use var instead of const (IE fix) #338

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

pleunv
Copy link
Contributor

@pleunv pleunv commented Aug 8, 2018

What kind of change does this PR introduce?

v0.22.0 introduced support for webpack nonces, however the code contains a const keyword which throws on IE10 and below. This PR replaces const with var so everybody's happy. I've verified this fix in IE10.

IE10 and below don't support the `const` keyword and are throwing as of v0.22.0. This PR replaces `const` with `var` so everybody's happy.
@jsf-clabot
Copy link

jsf-clabot commented Aug 8, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files           4        4           
  Lines          64       64           
  Branches       21       21           
=======================================
  Hits           63       63           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e973fe2...3485bb4. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title Use var instead of const (IE fix) fix(addStyles): use var instead of const (IE fix) Aug 8, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pleunv I will cut a release asap

@michael-ciniawsky
Copy link
Member

Released in v0.22.1 🎉

@pleunv
Copy link
Contributor Author

pleunv commented Aug 8, 2018

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants