Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate init typescriptLoader #641

Closed
wants to merge 1 commit into from
Closed

fix: duplicate init typescriptLoader #641

wants to merge 1 commit into from

Conversation

Vrainy
Copy link

@Vrainy Vrainy commented Apr 4, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

Each time the typescriptLoader is executed, ts-node will execute registerExtension() once.

Multiple executions of the typescriptLoader will get
require.extensions[ext] = wrapper(wrapper(wrapper(wrapper(wrapper(... wrapper(originalHandler))))).
ts-node source code

This will cause the out of memory when require.extensions[ext] is executed. #638

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, souds like node-ts has memory leak...

@alexander-akait alexander-akait mentioned this pull request Apr 4, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants