This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
fix: remove archived script-loader #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 40.54% 40.54%
=======================================
Files 4 4
Lines 74 74
Branches 12 12
=======================================
Hits 30 30
Misses 36 36
Partials 8 8
Continue to review full report at Codecov.
|
not really needed. requiring mocha.js directly sets up globals properly. has the effect of removing old raw-loader as well.
AviVahl
force-pushed
the
remove-script-loader
branch
from
8d6a165
to
12f4042
Compare
|
@evilebottnawi rebased to master. with the new proper e2e in place, I'm now confident when doing such changes. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Using
script-loaderis not really needed with today's mocha/webpack versions. Requiringmocha.jsdirectly sets up globals properly.Has the effect of removing old (indirect)
raw-loaderas well.Breaking Changes
None.
Additional Info