Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix runtime value #952

Merged

Conversation

ersachin3112
Copy link
Contributor

@ersachin3112 ersachin3112 commented Jun 13, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix runtime value

Fix #929

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #952 (0804929) into master (7f72caf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files           5        5           
  Lines         828      828           
  Branches      221      221           
=======================================
  Hits          748      748           
  Misses         70       70           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f72caf...0804929. Read the comment docs.

@alexander-akait alexander-akait merged commit 31c165f into webpack-contrib:master Jun 13, 2022
@vsn4ik
Copy link
Contributor

vsn4ik commented Jun 20, 2022

@alexander-akait what was the problem with merge my PR (#929) that was proposed over two months ago?

@alexander-akait
Copy link
Member

@vsn4ik We have failed CI and I missed your commit eventually

@vsn4ik
Copy link
Contributor

vsn4ik commented Jun 21, 2022

@alexander-akait Such situations discourage the desire to participate in product improvement

@alexander-akait
Copy link
Member

alexander-akait commented Jun 21, 2022

@vsn4ik sorry, I get a lot of issues/PRs every day (around 80-150+), so I can miss somethings, you can always ping me using my nickname (i.e. ping @alexander-akait)

@ersachin3112 ersachin3112 deleted the runtime-value-update branch July 1, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants