-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loader): add baseUri option when using loaderContext.importModule #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add more test to verify #872 is fixed
f031cdb
to
a67ba36
Compare
e655140
to
46d24f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 90.29% 90.33% +0.04%
==========================================
Files 5 5
Lines 824 828 +4
Branches 220 221 +1
==========================================
+ Hits 744 748 +4
Misses 70 70
Partials 10 10
Continue to review full report at Codecov.
|
46d24f3
to
ba299b1
Compare
ba299b1
to
febbb7e
Compare
@rodoabad did you use latest webpack? |
Yep I did. |
This PR contains a:
Motivation / Use-Case
webpack/webpack#15172
Breaking Changes
no
Additional Info
need webpack/webpack#15430 and release webpack