-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass absolute module path to serializer registration #894
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Just fyi: I am unathorized to run workflows, because this is my first contribution, so I'd be obliged if you could help me with that @alexander-akait |
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 6 6
Lines 795 795
Branches 216 216
=======================================
Hits 726 726
Misses 63 63
Partials 6 6
Continue to review full report at Codecov.
|
@alexander-akait sorry to bother, but can I ask for the workflow to be run again? I think linter will be happy this time |
Oh, ok, sure, i think the only complaint is the casing. Thanks |
@alexander-akait do you know any ETA estimates? I know @sokra is very busy, I'm not trying to rush anything, just to organize my work and to decide whether or not I fork the repo and host it myself with the patch applied xd |
Hope we will merge it today/tomorrow |
This PR contains a:
Motivation / Use-Case
#892
Breaking Changes
Additional Info