Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use finishModules if thread is less than or equal 1 #95

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

ricardogobbosouza
Copy link
Collaborator

Resolve #83

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #95 (9922b6b) into master (6fc6874) will decrease coverage by 0.39%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #95      +/-   ##
===========================================
- Coverage   100.00%   99.60%   -0.40%     
===========================================
  Files            8        8              
  Lines          253      255       +2     
  Branches        72       73       +1     
===========================================
+ Hits           253      254       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/index.js 98.46% <75.00%> (-1.54%) ⬇️
src/linter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc6874...9922b6b. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @jsg2021 Can you test locally?

@jsg2021
Copy link
Contributor

jsg2021 commented Apr 7, 2021

This does appear to resolve the threading performance regression :)

@ricardogobbosouza ricardogobbosouza merged commit c12e7be into master Apr 8, 2021
@ricardogobbosouza ricardogobbosouza deleted the fix-threads branch April 8, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression
3 participants